This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
Adding constructor database #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctemp
force-pushed
the
pay-2195-add-constructor-db
branch
2 times, most recently
from
bc48570 to
c6e9f05
Compare
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
marctemp
commented
Aug 1, 2022
| const claim = sequelize.define('claim', { | ||
| calculationId: { type: DataTypes.INTEGER, primaryKey: true, autoIncrement: true }, | ||
| paymentRequestId: DataTypes.INTEGER, | ||
| sbi: DataTypes.INTEGER, |
There was a problem hiding this comment.
We may need frn here too as a BIGINT. All payments are FRN focused so if it's possible to get from DWH, it might simplify matching.
Happy it can be added later.
There was a problem hiding this comment.
This would cause field duplication though...
|
SonarCloud Quality Gate failed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/SFI-2195