This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
SFI-2324 Get fundings data for statement constructor object #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwatson484
previously approved these changes
Sep 7, 2022
| where: { | ||
| calculationId | ||
| }, | ||
| raw: true |
There was a problem hiding this comment.
You could also use nest: true here which would mean that fundingOptions name attribute would be available as fundingOptions.name rather than 'fundingOptions.name'.
Makes the syntax a bit neater downstream in my opinion but leave it up to your judgement.
There was a problem hiding this comment.
Recommendation applied, many thanks
|
Kudos, SonarCloud Quality Gate passed! |
johnwatson484
approved these changes
Sep 7, 2022
AbidemiAdio
deleted the
SFI-2324-get-fundings-data-for-statement-constructor-object
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.