Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨add xml:id to notifications && add precedes/follows check #989

Merged
merged 3 commits into from
Feb 8, 2023
Merged

✨add xml:id to notifications && add precedes/follows check #989

merged 3 commits into from
Feb 8, 2023

Conversation

yinanazhou
Copy link
Member

Initial PR for Neon issues #986 and #905

Next step:

  • add action to fix the syllable that contains both precedes and follows
  • add copy-id button in the error log

@yinanazhou yinanazhou changed the base branch from master to develop February 5, 2023 21:49
@yinanazhou yinanazhou requested a review from softcat477 February 5, 2023 21:49
softcat477
softcat477 approved these changes Feb 6, 2023
View reviewed changes
Copy link

@softcat477 softcat477 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also close DDMAL/Rodan#784 if it is fixed by this PR

@yinanazhou yinanazhou merged commit 8ab8105 into develop Feb 8, 2023
@yinanazhou yinanazhou deleted the error-id-fix branch April 20, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softcat477 softcat477 softcat477 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinanazhou @softcat477