✨ Limit undo stack to latest 10 changes #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinh0
commented
Aug 19, 2022
| function handle (evt: MessageEvent): void { | ||
| function handle (this: NeonCore, evt: MessageEvent): void { |
There was a problem hiding this comment.
Adding typing for this keyword. This doesn't actually add a new argument for the function, it's just for TypeScript to type this properly.
jinh0
commented
Aug 19, 2022
Comment on lines
-352
to
+362
| this.undoStacks.get(pageURI).push(currentMEI); | ||
|
|
||
| // Add to undo stack: | ||
| // Remove the bottommost MEI string on the stack | ||
| // if the stack is > 10 strings | ||
| const undoStack = this.undoStacks.get(pageURI); | ||
| const len = undoStack.push(currentMEI); | ||
|
|
||
| if (len > 10) | ||
| this.undoStacks.set(pageURI, undoStack.slice(1)); | ||
|
|
||
| // Clear redo stack: |
There was a problem hiding this comment.
The new logic limiting undo stack to 10 strings
jinh0
commented
Aug 19, 2022
| @@ -451,20 +461,18 @@ class NeonCore { | |||
| * @returns If the action was undone. | |||
| */ | |||
| undo (pageURI: string): Promise<boolean> { | |||
There was a problem hiding this comment.
I refactored undo and redo while fixing the undo stack because I realized that we weren't actually resolving the promise in some conditions. The code works functionally the same as before.
yinanazhou
approved these changes
Aug 22, 2022
Also make our console.error into a console.warn since undo/redo fails only when there is nothing on the stack (which isn't that big of a deal).
jinh0
commented
Aug 22, 2022
| @@ -2,7 +2,6 @@ import * as Notification from './Notification'; | |||
| import NeonView from '../NeonView'; | |||
| import { convertStaffToSb } from './ConvertMei'; | |||
| import { EditorAction } from '../Types'; | |||
| import ZoomHandler from '../SingleView/Zoom'; | |||
There was a problem hiding this comment.
We don't use this import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.