Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard refactor and action fixes #957

Merged
merged 15 commits into from
Aug 22, 2022
Merged

Dashboard refactor and action fixes #957

merged 15 commits into from
Aug 22, 2022

Conversation

chetbae
Copy link
Contributor

@chetbae chetbae commented Aug 11, 2022 •
edited
Loading

Fixes/Features:

  • Added removing .mei extension from primary folio name when uploading
  • Implemented storing folio name as id value for tile HTML element, fixes shortened folio name's full value being lost therefore not opened properly
  • Added lose focus on folio selection when clicking on background
  • Improved folio selection architecture, supports shift selection, meta and shift click behaviour now mimics the familiar MacOS patterns
  • Added handling duplicate folio uploads by renaming as 'DuplicateFile(1)', 'DuplicateFile(2)', etc...
  • Fix broken promise chain, refreshing documents after uploading now works as expected
  • Fixed misnaming of folios when uploading multiple folios

Closes #833, closes #947

chetbae added 2 commits August 10, 2022 17:21
@chetbae
Capitalize camelcase filenames
223b270
@chetbae
✨Refactor dashboard actions...
36fc258 
...including multiple selections, open, delete, meta-select.

Deprecate manuscript actions - commented out for future implementation.

Filenames are structured separately from mei_filenames (based off mei_filename right now with .mei stripped) for renaming feature in the future.
@chetbae chetbae requested a review from yinanazhou August 11, 2022 03:43
@chetbae chetbae self-assigned this Aug 11, 2022
@chetbae
Copy link
Contributor Author

chetbae commented Aug 15, 2022

Ready for testing.
To-do: documentation in wiki, rewrite cypress tests to reflect refactoring.

@yinanazhou
Copy link
Member

Hi, I will test this PR after the cypress changes are done.

@chetbae
Copy link
Contributor Author

chetbae commented Aug 16, 2022

Fixed problems to existing tests!

@chetbae chetbae merged commit 78d5e88 into develop Aug 22, 2022
@chetbae chetbae deleted the dashboard-fixes branch August 22, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinanazhou yinanazhou yinanazhou approved these changes

Assignees

@chetbae chetbae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chetbae @yinanazhou