Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmd-select nc's for toggle ligature #819

Merged
merged 3 commits into from
May 14, 2022
Merged

Conversation

chetbae
Copy link
Contributor

@chetbae chetbae commented May 13, 2022

#797
Fix toggle ligature option not appearing for cmd+selecting nc's that could be converted to a ligature.

Note: podatus still shows the option to toggle ligature - tldr podatus and ligature presented as an svg is identical. But, toggle ligature on a podatus will not functionally change anything. Optimal fix coming soon!

@chetbae chetbae closed this May 13, 2022
@chetbae
Copy link
Contributor Author

chetbae commented May 13, 2022

Sorry! bad code, fixed in newest commit

@chetbae chetbae reopened this May 13, 2022
@chetbae chetbae requested a review from yinanazhou May 13, 2022 18:17
@chetbae chetbae self-assigned this May 13, 2022
@yinanazhou yinanazhou merged commit a050de5 into develop May 14, 2022
@chetbae chetbae deleted the toggle-ligature-fix branch May 16, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants