Update docs id attribute #1022
Merged
Update docs id attribute #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something was not working with directly accessing and updating each document entry 'id' attribute, using doc.setAttribute seemed to fix this problem. The 'id' attributes were updated for uplodatedDocs and sampleDocs as well.
The DocumentSelector.ts access of 'id' attribute for sampleDocs and uploadedDocs was updated as it was not working properly. Need to update this branch with current verion of develop before creating pull request.
|
Hi @zhannaklimanova, could you please provide the corresponding issue for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the functionality that sets the 'id' attribute for uploaded and selected documents in DocumentSelector.ts. Changes were manually tested.