Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create dir for output file #1242

Merged
merged 18 commits into from
Jan 23, 2025
Merged

feat: create dir for output file #1242

merged 18 commits into from
Jan 23, 2025

Conversation

cuhland
Copy link
Contributor

@cuhland cuhland commented Dec 9, 2024 •
edited by jkowalleck
Loading

fixes: #1241

  • implement new things
  • add tests
  • write history

@cuhland cuhland requested a review from a team as a code owner December 9, 2024 08:48
@cuhland cuhland force-pushed the create-dir-for-output branch from 52746b5 to 7faadf8 Compare December 9, 2024 08:50
@cuhland
Create dir if not exists
079b36b 
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
@cuhland cuhland force-pushed the create-dir-for-output branch from 7faadf8 to 079b36b Compare December 9, 2024 08:51
@jkowalleck jkowalleck added the enhancement New feature or request label Dec 9, 2024
@jkowalleck jkowalleck changed the title Create dir if not exists feat: create dir if not exists Dec 9, 2024
jkowalleck
jkowalleck reviewed Dec 9, 2024
View reviewed changes
@jkowalleck jkowalleck changed the title feat: create dir if not exists feat: create dir for output file Dec 9, 2024
@jkowalleck jkowalleck added the breaking-change breacking change. causes a new major version. label Dec 9, 2024
jkowalleck
jkowalleck reviewed Dec 9, 2024
View reviewed changes
jkowalleck
jkowalleck reviewed Dec 9, 2024
View reviewed changes
@jkowalleck jkowalleck added this to the v2.0.0 milestone Dec 9, 2024
@cuhland
Handle review comments
a9f21df 
- log the directory

Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
@cuhland cuhland force-pushed the create-dir-for-output branch from 1efc7da to a9f21df Compare December 9, 2024 10:09
jkowalleck
jkowalleck requested changes Dec 9, 2024
View reviewed changes
cuhland and others added 2 commits December 9, 2024 11:31
@cuhland @jkowalleck
Update src/cli.ts
661f2d9 
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: cu <42832096+cuhland@users.noreply.github.com>
@cuhland @jkowalleck
Update src/cli.ts
db22fb0 
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: cu <42832096+cuhland@users.noreply.github.com>
@jkowalleck jkowalleck self-requested a review December 10, 2024 12:29
@jkowalleck
Copy link
Member

Thanks @cuhland ,

this feature is considered for the next major version. Planned for early 2025.

jkowalleck
jkowalleck requested changes Dec 11, 2024
View reviewed changes
@jkowalleck
Update src/cli.ts
04f9736 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
dont create test dirs, let te tool do it for us
36627c1 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Update cli.edge-cases.test.js
0cddfe6 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Update cli.from-collected.test.js
eeb1504 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Update cli.args-pass-through.test.js
36e3cba 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge branch 'main' into create-dir-for-output
1c58e9d
@jkowalleck
roll back to working tests
537ae97 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test dir creation
3c5f237 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test dir creation
f038049 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
style
5b1f49c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test regex escaped
41f5b36 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge branch 'main' into create-dir-for-output
a620e37
@jkowalleck
Merge branch 'main' into create-dir-for-output
07fa2b3
@jkowalleck
Merge branch 'main' into create-dir-for-output
b64d352
@jkowalleck jkowalleck merged commit ab4e41f into CycloneDX:main Jan 23, 2025
31 checks passed
@jkowalleck
Copy link
Member

was released via https://github.com/CycloneDX/cyclonedx-node-npm/releases/tag/v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalleck jkowalleck jkowalleck approved these changes

Assignees
No one assigned
Labels
breaking-change breacking change. causes a new major version. enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

feat: create dir for output file
2 participants
@cuhland @jkowalleck