fix Charselect exploit #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crystalwarrior
requested changes
Mar 28, 2023
There was a problem hiding this comment.
It's supposed to do the permission check in the force_charselect section:
https://github.com/Crystalwarrior/KFO-Server/pull/86/files#diff-60ba0c0b584dbfd37a69ce61aa5de8f3e3adbd4e39457a97d704b7de23fed386R174
This command is also supposed to be usable by CM's and GM's in case someone is hoarding a character etc. but not allow normal users to force someone into a char
|
The macro only works for command definitions, not random functions |
|
better implementation merged into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyone can send anyone with a 1 in the IPID to the charselect using
/charselect 1 -1
after this only moderators will be able to do that