Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player count update #33

Merged
merged 10 commits into from
Feb 18, 2022
Merged

Player count update #33

merged 10 commits into from
Feb 18, 2022

Conversation

EstatoDeviato
Copy link
Contributor

closes #30

@Crystalwarrior
Copy link
Owner

Can you split this up so it only focuses on fixing the bug? Currently the PR has added features that I want to address in a different pr specific to them (such as mod count etc)

@EstatoDeviato
Copy link
Contributor Author

Sure!

@Crystalwarrior
Copy link
Owner

Hmm, looks good. Let's try it out.

@Crystalwarrior
Copy link
Owner

Crystalwarrior commented Feb 13, 2022 •
edited
Loading

Waaait wait wait, FA packet is kind of expensive. Wouldn't this create lag spikes any time a client triggers it?

@EstatoDeviato
Copy link
Contributor Author

I don't think so because it uses FA packet only if you are in hub_viewing

@EstatoDeviato
Copy link
Contributor Author

However I don't know how to upgrade player count when a player joins in to the server. I tried every new_client function but nothing

@EstatoDeviato
Copy link
Contributor Author

Maybe I can optimize something

Crystalwarrior
Crystalwarrior requested changes Feb 14, 2022
View reviewed changes
@EstatoDeviato
Copy link
Contributor Author

EstatoDeviato commented Feb 14, 2022 •
edited
Loading

to count players I made 2 loops instead of 3, because I need to divide the counters to hubs.
To send player count upgrade I made 1 loop instead of 3

EstatoDeviato
EstatoDeviato commented Feb 14, 2022
View reviewed changes
Copy link
Contributor Author

@EstatoDeviato EstatoDeviato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to count players I made 2 loops instead of 3, because I need to divide the counters to hubs.
To send players count upgrade I made 1 loop instead of 3

@Crystalwarrior Crystalwarrior merged commit f6de353 into Crystalwarrior:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crystalwarrior Crystalwarrior Crystalwarrior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player count doesn't update for hubs/areas in ARUP
2 participants
@EstatoDeviato @Crystalwarrior