Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing premium data points for organizations #1374

Merged
merged 33 commits into from
Aug 29, 2023

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented Aug 22, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 99be0c6

This pull request enhances the organization data model and service to support more features from the premium enrichment service. It updates the Organization model, the IOrganization interface, and the organizationEnrichmentService to align the data fields and types with the external API. It also adds more documentation and comments to the code.

🤖 Generated by Copilot at 99be0c6

Sing, O Muse, of the skillful coder who enriched the Organization
With many a precious field from the premium service of the gods
He mapped the keys of the response with cunning and precision
And shaped the IOrganization interface to match the model's laws

Why

How

🤖 Generated by Copilot at 99be0c6

  • Add new fields to Organization model and IOrganization interface to store additional data from premium enrichment service (link, link)
  • Fix typo and add comment in Organization model (link, link)
  • Update mappings and property names in organizationEnrichmentService to match enrichment response and model fields (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet self-assigned this Aug 22, 2023
@skwowet skwowet added the Improvement Created by Linear-GitHub Sync label Aug 22, 2023
@skwowet skwowet marked this pull request as ready for review August 24, 2023 19:13
@garrrikkotua garrrikkotua requested a review from themarolt August 29, 2023 12:47
@skwowet skwowet merged commit 30f1d63 into main Aug 29, 2023
@skwowet skwowet deleted the improvement/org-premium-data-endpoints branch August 29, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants