Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bodyText2 only if there's no style passed in parameters #96

Merged
merged 3 commits into from
May 15, 2023

Conversation

Tumist76
Copy link
Contributor

@Tumist76 Tumist76 commented Aug 5, 2021

Use of bodyText2 as a base style every time had led to some inconsistencies in text rendering in our case. I made bodyText2 usage conditional - only when there's no style passed.

Furthermore, I've added more granular control over MouseRegion usage as it may be not necessary in some cases and added more problems to text rendering when using Text.rich().

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Tumist76
❌ Cretezy
You have signed the CLA already but the status is still pending? Let us recheck it.

@Cretezy Cretezy merged commit f91c430 into Cretezy:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants