Added support for mailto: links. #8
Conversation
… be a linked "piotapps@gmail.com".
…l and added a separate EmailCallback
|
Resolved your comments, one discussion point left (see the TODO) |
| @@ -17,8 +20,12 @@ class Linkify extends StatelessWidget { | |||
| final TextStyle linkStyle; | |||
|
|
|||
| /// Callback for tapping a link | |||
| final LinkCallback onOpen; | |||
| final LinkCallback onLinkOpen; | |||
There was a problem hiding this comment.
Breaking change, will require a major bump.
| @@ -13,6 +13,19 @@ class LinkElement extends LinkifyElement { | |||
| } | |||
| } | |||
|
|
|||
| /// Represents an element containing an email address | |||
| class EmailElement extends LinkifyElement { | |||
| final String emailAddress; | |||
There was a problem hiding this comment.
Is there a case where the email address != displayed address?
There was a problem hiding this comment.
Not now I think.. But it will be when support for ?subject=...&body=... is added.
There was a problem hiding this comment.
I think that's still gonna be the same though, since subject, body, etc is simply gonna be properties (not shown)
| description: Turns text URLs into clickable inline links in text for Flutter. | ||
| version: 1.1.1 | ||
| description: Turns text URLs and Mailto links into clickable inline links in text for Flutter. | ||
| version: 1.2.0 |
There was a problem hiding this comment.
| version: 1.2.0 | |
| version: 2.0.0 |
To match the breaking change above.
We could support both onOpen and onOpenLink (and deprecate onOpen). To to you to make the decision!
|
@Cretezy Will have a look later. What about the TODO mentioned at flutter_linkify.dart#87 |
|
I'll take a look at this later tonight. Looks great thogh! |
|
@Cretezy any updates? |
|
Totally forgot about this, sorry! Will check when I'm home. |
|
Merged. Will prepare 2.0.0 release, I want to change the API a little. Thanks again! Great work |
EG: "mailto:piotapps@gmail.com" will be a linked "piotapps@gmail.com".
Later TODO: support for
?subject=...&body=...