Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText --> Text.rich #53

Merged
merged 1 commit into from
Nov 6, 2020
Merged

RichText --> Text.rich #53

merged 1 commit into from
Nov 6, 2020

Conversation

Sorunome
Copy link
Contributor

RichText introduces several problems, e.g. font scaling not working properly. People are meant to use Text.rich instead, where RichText is more meant to be a flutter-internal widget. See flutter/flutter#14675

As such, RichText might be renamed to RawText in the future anyways, to discourage its use flutter/flutter#24722

This PR replaces RichText with Text.rich

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Cretezy
Copy link
Owner

Cretezy commented Nov 6, 2020

LGTM!

@Cretezy Cretezy merged commit d90c83d into Cretezy:master Nov 6, 2020
MagTuxGit added a commit to MagTuxGit/flutter_linkify that referenced this pull request Mar 19, 2021
@MagTuxGit
Merge branch 'master_up'
186b549 
* master_up:
  v5.0.0: Add null-safety
  v4.1.0
  master (Cretezy#70)
  SelectableLinkify exposes `minLines` property. (Cretezy#74)
  v4.0.2: Add unit tests
  v4.0.1: Forgot to bump version in README
  v4.0.0: Upgrade linkify, minimum Flutter version, use Text.rich
  Add minimum Flutter version
  RichText --> Text.rich (Cretezy#53)

# Conflicts:
#	lib/flutter_linkify.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sorunome @CLAassistant @Cretezy