Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 Support #461

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Python 3.11 Support #461

merged 4 commits into from
Jan 22, 2024

Conversation

MattToast
Copy link
Member

@MattToast MattToast commented Jan 20, 2024 •
edited
Loading

Adds Python 3.11 to the SmartSim support matrix.

TODO before merge:

  • Run the full test suite against a super (I was running into "invalid instruction" problems earlier when attempting to start redis through SmartSim. Back of the envelope math says this should be unrelated to Python 3.11 support, there is a good chance I misconfigured my environment, but it's still good practice to check!)
  • Run the backends test against a machine with GPUs (again, back of the envelope says they should be fine, but doesn't hurt to confirm!)
  • Update the change log!

@MattToast MattToast added area: build Issues related to builds, makefiles, installs, etc area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations type: usability Issues related to ease of use labels Jan 20, 2024
@MattToast MattToast self-assigned this Jan 20, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35973b5) 90.75% compared to head (321a794) 90.75%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #461   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files           60       60           
  Lines         3830     3830           
========================================
  Hits          3476     3476           
  Misses         354      354

ashao
ashao requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tick those TODOs and I think you're good to go!

@MattToast MattToast requested a review from ashao January 22, 2024 19:51
@MattToast
Copy link
Member Author

TODOs have been addressed and this should be ready for re-review/merge! 🚀

@MattToast MattToast mentioned this pull request Jan 22, 2024
Closed
ashao
ashao approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it!

@MattToast MattToast merged commit 92a3c99 into CrayLabs:develop Jan 22, 2024
34 checks passed
ashao pushed a commit to ashao/SmartSim that referenced this pull request Jan 30, 2024
@MattToast @ashao
Python 3.11 Support (CrayLabs#461)
9922080 
Add Python 3.11 to SmartSim

[ committed by @MattToast ]
[ reviewed by @ashao ]
@MattToast MattToast deleted the py311 branch March 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashao ashao ashao approved these changes

Assignees

@MattToast MattToast

Labels
area: build Issues related to builds, makefiles, installs, etc area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations type: usability Issues related to ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattToast @ashao