Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing robustness on SLURM machines #381

Merged
merged 73 commits into from
Dec 11, 2023
Merged

Improve testing robustness on SLURM machines #381

Show file tree
Hide file tree
Changes from 59 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
c48db14
Update tests to pass on_wlm
ashao Oct 2, 2023
7e02516
Define make_test_dir and get_test_dir fixtures
al-rigazzi Oct 12, 2023
2f9882b
More permissive naming for caller_function
al-rigazzi Oct 12, 2023
978e177
Style
al-rigazzi Oct 12, 2023
0e25a4a
Update tests to pass on_wlm
ashao Oct 2, 2023
c6930c0
Respond to review feedback
ashao Oct 16, 2023
86e51f8
Modify for mpirun with PBS
ashao Oct 16, 2023
cc8c986
Merge branch 'fix_tests' of https://github.com/ashao/SmartSim into fi…
ashao Oct 16, 2023
89c2008
Fix db shutdown and some fixtures
al-rigazzi Oct 16, 2023
765c571
Update DBModel tests
al-rigazzi Oct 17, 2023
fde1efe
Merge branch 'develop' into test-tmp-dir
al-rigazzi Oct 17, 2023
ea6bac5
Begin adding a context manager for orchestrators in multidb cases
ashao Oct 17, 2023
662e4c5
Merge branch 'test-tmp-dir' of https://github.com/al-rigazzi/SmartSim…
ashao Oct 17, 2023
b46ccb9
More multidb tests wokring, stopping at test_multidb.py::test_multidb…
ashao Oct 18, 2023
30d3fe4
Fix start_in_context
al-rigazzi Oct 18, 2023
131310f
Fix fixture usage
al-rigazzi Oct 18, 2023
dc301bb
Fix get_status
al-rigazzi Oct 18, 2023
380c8ef
Fix mypy issues
al-rigazzi Oct 18, 2023
62b79b0
Fix a couple of tests
ashao Oct 18, 2023
34ee0c3
Merge branch 'fix_tests' of https://github.com/ashao/SmartSim into fi…
ashao Oct 18, 2023
ee39204
tests are passing on PBS
ashao Oct 18, 2023
9f8a623
Fix one last typo
ashao Oct 18, 2023
3769c90
Make reset_hosts work on LSF
al-rigazzi Oct 19, 2023
c959e17
Comply to mypy syntax for union
al-rigazzi Oct 19, 2023
336bebd
Update signatures in conftest.py
al-rigazzi Oct 25, 2023
a343e27
Address reviewer's comments
al-rigazzi Oct 26, 2023
2038471
Fix name collision in FileUtils
al-rigazzi Oct 26, 2023
9ff094a
Fix fixture usage
al-rigazzi Oct 26, 2023
ac89651
Fix lock scope
al-rigazzi Oct 27, 2023
f7be14a
Replace repeated module level function
ashao Oct 30, 2023
e2b9238
Remove extraneous print in add_batch_resources
ashao Oct 30, 2023
aa95d5e
Enforce type for batch resources
ashao Oct 30, 2023
9f4eac0
Reset license text after inadvertent find/replace
ashao Oct 31, 2023
e697f58
Fix SS env vars
al-rigazzi Nov 1, 2023
225b5b2
Merge branch 'develop' of https://github.com/CrayLabs/SmartSim into f…
al-rigazzi Nov 1, 2023
cce73db
Use db_identifier
al-rigazzi Nov 1, 2023
bd3ff35
Disable key prefixing for test colocated entities
al-rigazzi Nov 1, 2023
2eab465
Add test to validate uds socket file name
al-rigazzi Nov 2, 2023
fcdc5db
Remove "test_dir = test_dir"
al-rigazzi Nov 2, 2023
8524819
Fix typehinting
ashao Nov 2, 2023
be38db2
Address feedback from @drozt
ashao Nov 3, 2023
99f47f8
Separate db name and db id
al-rigazzi Nov 3, 2023
a9b3fff
Add test for db ids and names
al-rigazzi Nov 3, 2023
f664477
Fix db node test for local
al-rigazzi Nov 3, 2023
1b29f12
Addresse reviewer's comments
al-rigazzi Nov 9, 2023
bebbb04
Make socket filename unique in tests
al-rigazzi Nov 23, 2023
0b67edd
Fix smartredis test scripts
al-rigazzi Nov 24, 2023
05fe0b2
Make some asserts more helpful
al-rigazzi Nov 24, 2023
e66c65c
Patch TF multigpu tests
al-rigazzi Nov 25, 2023
a3842a4
Add info about num_test_devices
al-rigazzi Nov 25, 2023
05093b7
Add details to failing asserts in test_dbmodel
al-rigazzi Nov 26, 2023
1e101e7
Add mem cap to dataloader tests
al-rigazzi Nov 26, 2023
94d4790
Fix number of devices if not GPU
al-rigazzi Nov 26, 2023
dc78094
Merge branch 'develop' of https://github.com/CrayLabs/SmartSim into f…
al-rigazzi Nov 27, 2023
9af0c75
MyPy
al-rigazzi Nov 27, 2023
c68b2af
Merge branch 'develop' of https://github.com/CrayLabs/SmartSim into f…
al-rigazzi Nov 30, 2023
762db80
Spawn in TF saving/serializing in a new process to avoid a locked GPU
ashao Dec 1, 2023
31520a9
Revert "Spawn in TF saving/serializing in a new process to avoid a lo…
ashao Dec 1, 2023
b703bc9
Simplify the logic in QsubBatchSettings
ashao Dec 7, 2023
48defa2
Delete extraneous scripts
ashao Dec 8, 2023
b929ba8
Refactor QsubBatchSettings resources
ashao Dec 8, 2023
a0d8328
Merge branch 'develop' into fix_tests
al-rigazzi Dec 8, 2023
8e0e82f
Merge branch 'fix_tests' of https://github.com/ashao/SmartSim into fi…
al-rigazzi Dec 8, 2023
0979ced
Merge branch 'develop' into fix_tests
al-rigazzi Dec 8, 2023
2e72604
Delete misleading comment
al-rigazzi Dec 8, 2023
14c420d
Correct type hints and more robust resource validation
ashao Dec 8, 2023
bd4345e
Fix one use of | insteado t.Union
ashao Dec 9, 2023
f2123fa
Fix an incorrect typehint
ashao Dec 9, 2023
5ff7007
Yet another | instead of t.Union
ashao Dec 9, 2023
f485ad1
Remove extraneous assignment and blackify
ashao Dec 9, 2023
2824d69
Remove now invalid test and update type checking
ashao Dec 9, 2023
2358c48
Fix accidental collision with default value
ashao Dec 11, 2023
0663f5d
Update behaviour for test_create_pbs_batch
ashao Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ venv/
.venv/
env/
.env/
.env

# written upon install
smartsim/version.py
Expand Down
Loading