Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for RAI_PATH and lib path interactions #328

Merged
merged 11 commits into from
Aug 4, 2023
Merged

Add more tests for RAI_PATH and lib path interactions #328

merged 11 commits into from
Aug 4, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 24, 2023

Additional tests for interactions between RAI_PATH environment variable and default lib_path value when using configuration for RedisAI module.

@ankona ankona requested review from mellis13 and MattToast July 24, 2023 22:34
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #328 (9cefa8a) into develop (8ce3c1d) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #328   +/-   ##
========================================
  Coverage    87.20%   87.20%           
========================================
  Files           59       59           
  Lines         3526     3526           
========================================
  Hits          3075     3075           
  Misses         451      451

mellis13
mellis13 previously requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these additional tests!

@ankona ankona requested a review from mellis13 July 28, 2023 21:03
ankona
ankona commented Aug 1, 2023
View reviewed changes
MattToast
MattToast approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! This should definaltly make sure taht our RAI path is operating as expected if a user decideds to offer their own!

Approved pending a couple of small requests!

@ankona ankona requested a review from MattToast August 4, 2023 17:45
MattToast
MattToast approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ankona ankona removed the request for review from mellis13 August 4, 2023 20:07
@ankona ankona dismissed mellis13’s stale review August 4, 2023 20:08

completed all changes

@ankona ankona merged commit 1d2ec9f into CrayLabs:develop Aug 4, 2023
@ankona ankona deleted the oss464 branch August 4, 2023 20:10
@MattToast MattToast added the area: test Issues related to the test suite label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattToast MattToast MattToast approved these changes

@mellis13 mellis13 mellis13 left review comments

Assignees
No one assigned
Labels
area: test Issues related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankona @mellis13 @MattToast