-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typehints #295
Typehints #295
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #295 +/- ##
===========================================
+ Coverage 87.64% 87.72% +0.08%
===========================================
Files 58 59 +1
Lines 3319 3390 +71
===========================================
+ Hits 2909 2974 +65
- Misses 410 416 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small questions, but the vast majority of this PR looks really good. Thanks for all the hard work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all your hard work on this one.
Btw, I really like the recent change of defining type alias names for come of the more complex types. We should replicate that elsewhere as it makes sense to do so to take advantage of the readability gains it provides
No description provided.