Avoid checking for alloc_specs if it is not defined #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-rigazzi
requested review from
ashao,
ben-albrecht and
mellis13
and removed request for
mellis13 and
ashao
ben-albrecht
approved these changes
Jun 3, 2022
| @@ -8,6 +8,8 @@ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Would you mind adding a short comment here explaining why alloc_specs might not be defined? E.g.,
# Slurm or PBS system can sometimes be set up such that not all
# environment variables associated with 'alloc_specs' are populated,
# so 'alloc_specs'-related tests only run when the environment variables are set
There was a problem hiding this comment.
I'll add it to the tests. This feature is still under-documented, anyhow.
Codecov Report
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
- Coverage 84.12% 84.06% -0.07%
===========================================
Files 58 58
Lines 3244 3244
===========================================
- Hits 2729 2727 -2
- Misses 515 517 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates issues when a Slurm or PBS system is set up so that not all environment variables are populated.
If the
alloc_specsfixture is not defined (see commit 4bd5e23), the functions using it won't be testsd.