-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marshaler to codec #1545
marshaler to codec #1545
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 58.00% 58.03% +0.02%
==========================================
Files 64 64
Lines 8640 8640
==========================================
+ Hits 5012 5014 +2
+ Misses 3215 3214 -1
+ Partials 413 412 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Just few small changes are required, then it is good to go! 💯
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* marshaler to codec * Update tests/e2e/ibc_fees_test.go Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> * Update tests/e2e/ibc_fees_test.go Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> * fix a few remaining issues --------- Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
SDK has changed verbiage and this PR changes the term "marshaler" to
codec to match