implicit memory aliasing

CosmWasm · Aug 24, 2023 · fcecbf6 · fcecbf6
1 parent 2161113
commit fcecbf6
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 0 deletions.
diff --git a/x/wasm/keeper/genesis.go b/x/wasm/keeper/genesis.go
@@ -45,6 +45,7 @@ func InitGenesis(ctx sdk.Context, keeper *Keeper, data types.GenesisState) ([]ab
 
 	var maxContractID int
 	for i, contract := range data.Contracts {
+		contract := contract
 		contractAddr, err := sdk.AccAddressFromBech32(contract.ContractAddress)
 		if err != nil {
 			return nil, errorsmod.Wrapf(err, "address in contract number %d", i)

diff --git a/x/wasm/keeper/handler_plugin_test.go b/x/wasm/keeper/handler_plugin_test.go
@@ -304,6 +304,7 @@ func TestIBCRawPacketHandler(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			capturedPacket = nil
 			// when
@@ -386,6 +387,7 @@ func TestBurnCoinMessageHandlerIntegration(t *testing.T) {
 	}
 	parentCtx := ctx
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			ctx, _ = parentCtx.CacheContext()
 			k.wasmVM = &wasmtesting.MockWasmer{ExecuteFn: func(codeID wasmvm.Checksum, env wasmvmtypes.Env, info wasmvmtypes.MessageInfo, executeMsg []byte, store wasmvm.KVStore, goapi wasmvm.GoAPI, querier wasmvm.Querier, gasMeter wasmvm.GasMeter, gasLimit uint64, deserCost wasmvmtypes.UFraction) (*wasmvmtypes.Response, uint64, error) {

diff --git a/x/wasm/keeper/keeper_test.go b/x/wasm/keeper/keeper_test.go
@@ -544,6 +544,7 @@ func TestInstantiateWithPermissions(t *testing.T) {
 		},
 	}
 	for msg, spec := range specs {
+		spec := spec
 		t.Run(msg, func(t *testing.T) {
 			ctx, keepers := CreateTestInput(t, false, AvailableCapabilities)
 			accKeeper, bankKeeper, keeper := keepers.AccountKeeper, keepers.BankKeeper, keepers.ContractKeeper

diff --git a/x/wasm/keeper/msg_server_integration_test.go b/x/wasm/keeper/msg_server_integration_test.go
@@ -127,6 +127,7 @@ func TestUpdateParams(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			err := wasmApp.WasmKeeper.SetParams(ctx, types.DefaultParams())
 			require.NoError(t, err)
@@ -215,6 +216,7 @@ func TestAddCodeUploadParamsAddresses(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			err := wasmApp.WasmKeeper.SetParams(ctx, types.Params{
 				CodeUploadAccess:             spec.uploadConfig,
@@ -311,6 +313,7 @@ func TestRemoveCodeUploadParamsAddresses(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			err := wasmApp.WasmKeeper.SetParams(ctx, types.Params{
 				CodeUploadAccess:             spec.uploadConfig,

diff --git a/x/wasm/keeper/proposal_integration_test.go b/x/wasm/keeper/proposal_integration_test.go
@@ -620,6 +620,7 @@ func TestAdminProposals(t *testing.T) {
 		},
 	}
 	for msg, spec := range specs {
+		spec := spec
 		t.Run(msg, func(t *testing.T) {
 			ctx, keepers := CreateTestInput(t, false, "staking")
 			wasmKeeper := keepers.WasmKeeper

diff --git a/x/wasm/keeper/querier_test.go b/x/wasm/keeper/querier_test.go
@@ -448,6 +448,7 @@ func TestQueryContractHistory(t *testing.T) {
 		},
 	}
 	for msg, spec := range specs {
+		spec := spec
 		t.Run(msg, func(t *testing.T) {
 			xCtx, _ := ctx.CacheContext()
 
@@ -520,6 +521,7 @@ func TestQueryCodeList(t *testing.T) {
 	}
 
 	for msg, spec := range specs {
+		spec := spec
 		t.Run(msg, func(t *testing.T) {
 			xCtx, _ := ctx.CacheContext()
 
@@ -596,6 +598,7 @@ func TestQueryContractInfo(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			xCtx, _ := ctx.CacheContext()
 			k.mustStoreContractInfo(xCtx, contractAddr, &spec.stored)

diff --git a/x/wasm/keeper/query_plugins_test.go b/x/wasm/keeper/query_plugins_test.go
@@ -806,6 +806,7 @@ func TestDistributionQuerier(t *testing.T) {
 		},
 	}
 	for name, spec := range specs {
+		spec := spec
 		t.Run(name, func(t *testing.T) {
 			mock := distrKeeperMock{GetDelegatorWithdrawAddrFn: spec.mockFn}
 			q := keeper.DistributionQuerier(mock)

diff --git a/x/wasm/types/proposal_test.go b/x/wasm/types/proposal_test.go
@@ -993,6 +993,7 @@ code_ids:
 		},
 	}
 	for msg, spec := range specs {
+		spec := spec
 		t.Run(msg, func(t *testing.T) {
 			v, err := yaml.Marshal(&spec.src)
 			require.NoError(t, err)