Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: fix accidental termination of portMappingLoop #1906

Merged
merged 1 commit into from
Feb 7, 2024
Merged

p2p: fix accidental termination of portMappingLoop #1906

merged 1 commit into from
Feb 7, 2024

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Feb 7, 2024

No description provided.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0c9ad6e) 52.86% compared to head (4818cf6) 52.82%.
Report is 473 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   52.86%   52.82%   -0.04%     
==========================================
  Files         494      494              
  Lines       60506    60506              
==========================================
- Hits        31984    31963      -21     
- Misses      26080    26099      +19     
- Partials     2442     2444       +2     
Files Coverage Δ
p2p/server_nat.go 73.62% <0.00%> (ø)

... and 11 files with indirect coverage changes

@ucwong ucwong merged commit c0bf4ea into master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants