Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require block_body_root instead of full block body #437

Closed
ajsutton opened this issue Oct 19, 2021 · 1 comment
Closed

Only require block_body_root instead of full block body #437

ajsutton opened this issue Oct 19, 2021 · 1 comment
Assignees
Labels
TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@ajsutton
Copy link
Contributor

ajsutton commented Oct 19, 2021

Currently the Web3Signer API requires sending the entire beacon block body when signing blocks which is a lot of data and will get significantly bigger after the merge. The contents of the block body do not affect whether signing is slashable so could be safely replaced by the block body root.

To preserve backwards compatibility I'd suggest updating Web3Signer to accept block_body_root as a field and only if it's not provided to then look for block_body. Only one of them is required.

Tasks

  • Update Teku to only send the block_body_root in the block signing request
  • Update schema to add support block body root field
  • Compute signing root for Beacon block using block body root

Acceptance Criteria

  • Block body can still be used for the forks prior to the Bellatrix fork
  • Block body root can be used instead of the full block body
@usmansaleem
Copy link
Collaborator

Fixed by #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Development

No branches or pull requests

4 participants