Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge] Implements payloadId on-the-fly retrieval for post-merge blocks #4708

Merged
merged 3 commits into from
Nov 30, 2021
Merged

[Merge] Implements payloadId on-the-fly retrieval for post-merge blocks #4708

merged 3 commits into from
Nov 30, 2021

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 26, 2021 •
edited
Loading

PR Description

  • implements payloadId on-the-fly retrieval for post-merge blocks

  • more precisely set lastForkChoiceStateCorrectlyBuildsOnTop, so we will resolve payloadIdFuture only when we expect non-empty payloadId.

Fixed Issue(s)

fixes #4668

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor Author

tbenr commented Nov 26, 2021 •
edited
Loading

I'm still relying on lastForkChoiceState if present. I don't know if makes sense anymore.

@tbenr tbenr force-pushed the on_the_fly_payloadid_retrival_postmerge branch from c3f01ea to 5e7af74 Compare November 28, 2021 12:23
ajsutton
ajsutton approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would just be nice to tidy up the exception handling a little.

tbenr added 3 commits November 30, 2021 09:11
@tbenr
more precisely set lastForkChoiceStateCorrectlyBuildsOnTop, so we wil…
88f75fa 
…l resolve payloadIdFuture only when we expect non-empty payloadId.

implements payloadId on-the-fly retrieval for post-merge blocks
@tbenr
cleanup doMerge function in unit test based on setTerminalBlockHash c…
ac4bd50 
…hanges in last PR
@tbenr
better exception handling
2e065ca
@tbenr tbenr force-pushed the on_the_fly_payloadid_retrival_postmerge branch from 301c182 to 2e065ca Compare November 30, 2021 08:33
@tbenr tbenr merged commit 38a9920 into Consensys:master Nov 30, 2021
@tbenr tbenr deleted the on_the_fly_payloadid_retrival_postmerge branch November 30, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Merge] Implement async pipelined execution engine calls
2 participants
@tbenr @ajsutton