Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Pantheon packages directly rather than copy the code in #26

Closed
benjaminion opened this issue Oct 25, 2018 · 1 comment
Closed

Comments

@benjaminion
Copy link
Contributor

We should investigate bringing in stuff like net.consensys.pantheon.util.uint and net.consensys.pantheon.util.bytes as dependencies rather than copy-pasting the code into beacon chain packages. (If we even need these.)

@akhila-raju akhila-raju added the code style 💅 This issue or pull request makes our code prettier label Dec 20, 2018
jrhea added a commit that referenced this issue Dec 20, 2018
* added slot scheduler

* initial work to add a slotScheduler

* stubbed out methods for slot, block and epoch processing

* Fixed package imports that didn't match folders. Fixed slot.increment() and errorprone packge

* fixed incorrect reference to serviceFacotry

* created state transition class, new events and stubbed methods to implement for new slot, block and epochs
jrhea pushed a commit that referenced this issue Dec 20, 2018
* add VRC contract changes from Eth 2.0 spec

* add compile contract

* add vrc scaffold

* add decorators to suppress warnings

* pull pegasys master

* proof of concept commit

* code clean up, refactor

* reorg of vrc module, renamed pow

* forgive me of my sins spotlessApply be thy name

* package name fixes

* spotlessApply

* Updates Beacon State fields and adds Beacon State constructor (#42)

* Update Beacon State fields and add constructor

* Ran Spotless to fix build error.

* Adds default constructor to bypass build error.

* resolves #38.  Errorprone causes issues with the build when this setting is on check('FieldCanBeFinal', CheckSeverity.WARN) (#44)

* Slot processing stubs (#26)

* added slot scheduler

* initial work to add a slotScheduler

* stubbed out methods for slot, block and epoch processing

* Fixed package imports that didn't match folders. Fixed slot.increment() and errorprone packge

* fixed incorrect reference to serviceFacotry

* created state transition class, new events and stubbed methods to implement for new slot, block and epochs

* changed package in pow form net.consensys to tech.pegasys

* removing old BeaconChainServiceFile

* add clean step to build, remove vrc from settings.gradle and change vrc to pow in .gitignore
@jrhea
Copy link
Contributor

jrhea commented Feb 9, 2019

This has been addressed

@jrhea jrhea closed this as completed Feb 9, 2019
zilm13 added a commit to zilm13/teku that referenced this issue Apr 30, 2024
* removed all Electra features
* renamed from Electra to EIP7594, compatible with spec config
* configs updated to be close to those in spec
* fixed bug with kzg_commitment_inclusion_proof size
* fixed all tests
* modified acceptance test BlockProposalAcceptanceTest to ensure we could run up to EIP7594 fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants