tiny cleanups on BlockBlobSidecarsTrackersPoolImpl (#8972)

Consensys · Jan 8, 2025 · c0a17cf · c0a17cf
1 parent 85ca2b5
commit c0a17cf
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java b/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java
@@ -477,7 +477,6 @@ public synchronized int getTotalBlobSidecarsTrackers() {
     return blockBlobSidecarsTrackers.size();
   }
 
-  @SuppressWarnings("FutureReturnValueIgnored")
   private BlockBlobSidecarsTracker internalOnNewBlock(
       final SignedBeaconBlock block, final Optional<RemoteOrigin> remoteOrigin) {
     final SlotAndBlockRoot slotAndBlockRoot = block.getSlotAndBlockRoot();
@@ -502,19 +501,21 @@ private BlockBlobSidecarsTracker internalOnNewBlock(
               if (!existingTracker.isComplete()) {
                 // we missed the opportunity to complete the blob sidecars via local EL and RPC
                 // (since the block is required to be known) Let's try now
-                asyncRunner.runAsync(
-                    () ->
-                        fetchMissingBlobsFromLocalEL(slotAndBlockRoot)
-                            .handleException(this::logLocalElBlobsLookupFailure)
-                            .thenRun(
-                                () -> {
-                                  // only run if RPC block fetch has happened ( no blobs RPC fetch
-                                  // has occurred)
-                                  if (existingTracker.isRpcBlockFetchTriggered()) {
-                                    fetchMissingBlockOrBlobsFromRPC(slotAndBlockRoot);
-                                  }
-                                })
-                            .finish(this::logBlockOrBlobsRPCFailure));
+                asyncRunner
+                    .runAsync(
+                        () ->
+                            fetchMissingBlobsFromLocalEL(slotAndBlockRoot)
+                                .handleException(this::logLocalElBlobsLookupFailure)
+                                .thenRun(
+                                    () -> {
+                                      // only run if RPC block fetch has happened
+                                      // (no blobs RPC fetch has occurred)
+                                      if (existingTracker.isRpcBlockFetchTriggered()) {
+                                        fetchMissingBlockOrBlobsFromRPC(slotAndBlockRoot);
+                                      }
+                                    })
+                                .handleException(this::logBlockOrBlobsRPCFailure))
+                    .ifExceptionGetsHereRaiseABug();
               }
             });