Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update readme #59

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Feat/update readme #59

merged 6 commits into from
Feb 20, 2024

Conversation

Julink-eth
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LINEASCAN_API_KEY is missing
Also we should remove the ETHERSCAN_API_KEY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it since you need it to verify the contract when deploying on L1, you need both.
Adding LINEASCAN_API_KEY to the .env.example

@phoax phoax merged commit 3c68a18 into main Feb 20, 2024
1 check passed
@Julink-eth Julink-eth deleted the feat/update-readme branch February 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants