chore: better variable name + natspec

Consensys · Jul 17, 2024 · a796466 · a796466
1 parent e538ec8
commit a796466
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/linea-state-verifier/contracts/EVMFetchTarget.sol b/packages/linea-state-verifier/contracts/EVMFetchTarget.sol
@@ -15,6 +15,7 @@ abstract contract EVMFetchTarget {
 
     /**
      * @dev Internal callback function invoked by CCIP-Read in response to a `getStorageSlots` request.
+     * @dev Only the first 32 bytes are used for callbackData and is never longer than 32 bytes
      */
     function getStorageSlotsCallback(
         bytes calldata response,
@@ -33,13 +34,13 @@ abstract contract EVMFetchTarget {
                 (IEVMVerifier, address, bytes32[], bytes[], bytes4, bytes)
             );
 
-        uint256 l2BlockRangeAccepted = uint256(bytes32(callbackData));
+        uint256 acceptedL2BlockRangeLength = uint256(bytes32(callbackData));
         bytes[] memory values = verifier.getStorageValues(
             addr,
             commands,
             constants,
             proof,
-            l2BlockRangeAccepted
+            acceptedL2BlockRangeLength
         );
         if (values.length != commands.length) {
             revert ResponseLengthMismatch(values.length, commands.length);

diff --git a/packages/linea-state-verifier/contracts/IEVMVerifier.sol b/packages/linea-state-verifier/contracts/IEVMVerifier.sol
@@ -9,6 +9,6 @@ interface IEVMVerifier {
         bytes32[] memory commands,
         bytes[] memory constants,
         bytes memory proof,
-        uint256 l2BlockRangeAccepted
+        uint256 acceptedL2BlockRangeLength
     ) external view returns (bytes[] memory values);
 }
diff --git a/packages/linea-state-verifier/contracts/LineaSparseProofVerifier.sol b/packages/linea-state-verifier/contracts/LineaSparseProofVerifier.sol
@@ -26,7 +26,7 @@ contract LineaSparseProofVerifier is IEVMVerifier {
         bytes32[] memory commands,
         bytes[] memory constants,
         bytes memory proof,
-        uint256 l2BlockRangeAccepted
+        uint256 acceptedL2BlockRangeLength
     ) external view returns (bytes[] memory values) {
         (
             uint256 blockNo,
@@ -40,9 +40,9 @@ contract LineaSparseProofVerifier is IEVMVerifier {
         // Check that the L2 block number used is a recent one and is part of the range accepted
         uint256 currentL2BlockNumber = IRollup(_rollup).currentL2BlockNumber();
         require(
-            (currentL2BlockNumber <= l2BlockRangeAccepted &&
+            (currentL2BlockNumber <= acceptedL2BlockRangeLength &&
                 blockNo <= currentL2BlockNumber) ||
-                blockNo >= currentL2BlockNumber - l2BlockRangeAccepted,
+                blockNo >= currentL2BlockNumber - acceptedL2BlockRangeLength,
             "LineaSparseProofVerifier: block not in range accepted"
         );