Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier needs to perform a subgroup check on proof points #2

Closed
ggutoski opened this issue Feb 26, 2020 · 0 comments
Closed

Verifier needs to perform a subgroup check on proof points #2

ggutoski opened this issue Feb 26, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ggutoski
Copy link
Contributor

@kobigurk has observed that the gnark verifier currently does not check a purported Groth16 proof to ensure that its points are actually in the correct elliptic curve subgroup (G1 or G2). It is known that these checks are necessary to thwart certain attacks on the protocol. See 2019/814 - Faster Subgroup Checks for BLS12-381 and references therein for state-of-the-art solutions to this issue.

@ggutoski ggutoski added the bug Something isn't working label Feb 26, 2020
ThomasPiellard added a commit that referenced this issue Sep 23, 2020
@gbotrel gbotrel closed this as completed Sep 23, 2020
ruslangm referenced this issue in ruslangm/gnark Dec 29, 2022
ThomasPiellard added a commit to ThomasPiellard/gnark that referenced this issue Jul 9, 2024
style: cleaner computation nb BSB commitments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants