Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caret devDependencies #69

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Use caret devDependencies #69

merged 1 commit into from
Mar 9, 2018

Conversation

pgoldrbx
Copy link
Contributor

@pgoldrbx pgoldrbx commented Mar 6, 2018

Description

Use caret semver in devDependencies to reduce noise from Renovate app and package updates. We could choose to do this after #62 or in parallel.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore, documentation, cleanup

Related Issue

Tangentially related: #62

Motivation and Context

Renovate opens a PR for each package update. This creates a lot of noise when all dev dependencies are pinned. Using caret-range will reduce PR noise.

How Has This Been Tested?

n/a

Screenshots (if appropriate):

n/a

Checklist:

  • My code follows the code style of this project.
  • [n/a] I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • [n/a] I have added tests to cover my changes.
  • All new and existing tests passed.

@pgoldrbx pgoldrbx added the chore label Mar 6, 2018
@pgoldrbx pgoldrbx self-assigned this Mar 6, 2018
@pgoldrbx pgoldrbx requested review from taveras and gautamarora March 6, 2018 20:04
Copy link
Contributor

@taveras taveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! did we need a package-lock.json update as well?

@pgoldrbx
Copy link
Contributor Author

pgoldrbx commented Mar 6, 2018

@taveras no, these are the current versions, so the lockfile is up to date

@taveras taveras merged commit 764f27e into CondeNast:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants