Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter null files & added error notification #2387

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

headri
Copy link
Contributor

@headri headri commented Mar 12, 2025

When you share a collection with an element containing a NMR File and the detail level is < 3 (not allowed to read attachments):
There was an error from reading (null) files.

  • Added check for null files.
  • Added error message if all files are null because user is not allowed to read them.
    • But not if no files are found (e.g. no ids given)

Remaining issue

An empty NMR Editor is still opened. User may overlook error notification.
Editor is opened before files are fetched (async), therefore preventing it is not simple.
Maybe close it after getting files failed?

@headri headri requested a review from PiTrem March 12, 2025 13:43
Copy link

LCOV of commit 6cc294c during Continuous Integration #4636

Summary coverage rate:
  lines......: 67.0% (15511 of 23139 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@headri headri force-pushed the 286-nmrium-on-sharedsync-data branch from 6cc294c to 2e3ddb7 Compare March 13, 2025 11:49
Copy link

LCOV of commit 2e3ddb7 during Continuous Integration #4642

Summary coverage rate:
  lines......: 67.0% (15495 of 23139 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant