improve error message on invalid WOPI host #7842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Dec 15, 2023
Rash419
force-pushed
the
imprv-wopi-err-msg
branch
from
6ad5048 to
ca513fd
Compare
eszkadev
reviewed
Dec 15, 2023
- before this patch when socket connection failed, we used to show the same error for socket connection failure and send the 'Action_Load_Resp' with same errorMsg - now we show/send different message for unauthorized and loading failure Signed-off-by: Rash419 <rashesh.padia@collabora.com> Change-Id: I71b1b7f8e2eca93790d068583370787825911a41
Rash419
force-pushed
the
imprv-wopi-err-msg
branch
from
ca513fd to
1be8e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #7709
Change-Id: I71b1b7f8e2eca93790d068583370787825911a41