Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect asyncInstall lifecycle #11252

Merged
merged 1 commit into from
Feb 28, 2025
Merged

protect asyncInstall lifecycle #11252

merged 1 commit into from
Feb 28, 2025

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Feb 27, 2025

RequestVettingStation can complete and take down its PresetsInstallTask if the required subforkit is already available

Change-Id: I7b2ec831158022e904bb28223053150543a2a241

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

RequestVettingStation can complete and take down its PresetsInstallTask
if the required subforkit is already available

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I7b2ec831158022e904bb28223053150543a2a241
@caolanm caolanm requested a review from codewithvk February 27, 2025 20:29
@caolanm
Copy link
Contributor Author

caolanm commented Feb 27, 2025

@codewithvk does this address the issue you had?

Copy link
Contributor

@codewithvk codewithvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Workes for me. Thanks :)

@Rash419 Rash419 merged commit 652e235 into master Feb 28, 2025
14 checks passed
@Rash419 Rash419 deleted the private/caolan/preset_fixes branch February 28, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants