split tile queue into per-canonical-viewid queues #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/tiletweaking
branch
from
89aaaef to
03945da
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
caolanm
force-pushed
the
private/caolan/tiletweaking
branch
from
84ecb85 to
8ee7c5c
Compare
mmeeks
approved these changes
Feb 28, 2025
| } | ||
| if (maxPrio == std::numeric_limits<float>::min()) | ||
| LOG_WRN("No sessions match this viewId " << desc.getNormalizedViewId()); | ||
| // LOG_TRC("Priority for tile " << desc.generateID() << " is " << maxPrio); | ||
| return maxPrio; | ||
| } | ||
|
|
||
| std::vector<TilePrioritizer::ViewIdInactivity> Document::getViewIdsByInactivity() const |
| @@ -1275,35 +1275,34 @@ bool ChildSession::clientVisibleArea(const StringVector& tokens) | |||
| return true; | |||
| } | |||
|
|
|||
| float ChildSession::getTilePriority(const TileDesc &tile) const | |||
| TilePrioritizer::Priority ChildSession::getTilePriority(const TileDesc &tile) const | |||
| virtual float getTilePriority(const TileDesc &) const { return 0.0; } | ||
|
|
||
| enum class Priority { | ||
| NONE = -1, // an error |
There was a problem hiding this comment.
Good this is the right way around - amusingly the core scheduler's priority enum is inverted - so small values are high priority for no really obvious reason ;-)
caolanm
force-pushed
the
private/caolan/tiletweaking
branch
from
a780510 to
ab86029
Compare
handle the queue associated with the least inactive session first. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ib14932b20f90d634dca35e9eacef8b005a4a20b7
…evels drops specific check of readonly viewers and combining factors in general. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ib2911e956e295ecaf92474bd222e5c30d470b702
caolanm
force-pushed
the
private/caolan/tiletweaking
branch
from
ab86029 to
cb824fb
Compare
mmeeks
approved these changes
Feb 28, 2025
… rows Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I33e46b4cfd039a82d082c959dbf0de7d7323834d
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ia8c6fe6092d893bc58f2544090607401dbaf1811
since: commit ef4cf82 CommitDate: Tue Dec 17 13:27:57 2024 +0000 Simplify preview merging special cases. so lets drop it and remove the angst Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I2c69daaab3671eba7d9db3220800554c80c9cf9b
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I181e6e84ac773af36290529c9629fd1871327a8c
caolanm
force-pushed
the
private/caolan/tiletweaking
branch
from
cb824fb to
c3fcc86
Compare
eszkadev
reviewed
Mar 3, 2025
| @@ -987,7 +987,7 @@ void Document::renderTiles(TileCombined &tileCombined) | |||
| } | |||
|
|
|||
| // if necessary select a suitable rendering view eg. with 'show non-printing chars' | |||
| if (tileCombined.getCanonicalViewId()) | |||
| if (tileCombined.getCanonicalViewId() != CanonicalViewId::None) | |||
There was a problem hiding this comment.
should we allow Invalid here ?
There was a problem hiding this comment.
It was the case before that only 0 was checked for here, so that's unchanged. There are two "special" numbers used for CanonicalViewIds, -1 and 0, and it's a little unclear if that's intentional. I only wanted to capture existing practice with this enumification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle the queue associated with the least inactive session first.
Change-Id: Ib14932b20f90d634dca35e9eacef8b005a4a20b7
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay