Use app variables instead of latlng conversion. #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Id232cee5fe59c198dec8f0b5223ce84ede915216
|
@Darshan-upadhyay1110 can you check when you have time? |
Sure also i am working on Ruler file converting this file to Ts |
|
@Darshan-upadhyay1110 cool :) So this review will be even easier i hope. |
Darshan-upadhyay1110
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Tested , works good. This makes logic more simple thanks @gokaysatir :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id232cee5fe59c198dec8f0b5223ce84ede915216
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay