Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app.file.viewedRectangle instead of latlng. #10893

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gokaysatir
Copy link
Contributor

Change-Id: Icd084deedda131624bc123da24817ba23b7b0db2

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@gokaysatir gokaysatir requested a review from eszkadev January 10, 2025 09:22
@eszkadev
Copy link
Contributor

please rebase, fails on all tests which were unstable before, but now seem to pass

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Icd084deedda131624bc123da24817ba23b7b0db2
@gokaysatir gokaysatir force-pushed the private/gokay/latlng-2 branch from c35fde9 to 012d69a Compare January 10, 2025 13:47
@gokaysatir gokaysatir requested review from mcecchetti and removed request for eszkadev January 13, 2025 16:45
Copy link
Contributor

@mcecchetti mcecchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gokaysatir gokaysatir merged commit 1595644 into master Jan 14, 2025
14 checks passed
@gokaysatir gokaysatir deleted the private/gokay/latlng-2 branch January 14, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants