Seccomp: filter more syscalls #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeeks
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
That's fine I expect we could also do:
BPF_STMT(BPF_RET | BPF_K, SECCOMP_RET_ERRNO | EPERM),
or somesuch for this which might make it safer; I expect that failing execve more gracefully may protect us against termination in a number of code-paths where 'helpers' are exec'd - no doubt there is some find-all-printers thing or xdg-open type spawning lurking there - and we don't want data-loss =)
We should also clobber 'execveat' I think =)
caolanm
force-pushed
the
private/caolan/add_to_seccomp
branch
from
7d85675 to
c4d4506
Compare
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ia17360035035418ada519cf758e38be35c01a177
caolanm
force-pushed
the
private/caolan/add_to_seccomp
branch
from
c4d4506 to
29a4517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ia17360035035418ada519cf758e38be35c01a177
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay