feat: Add user label to mention #10556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
juliusknorr
reviewed
Nov 21, 2024
juliusknorr
reviewed
Nov 21, 2024
This optional extra parameter allows defining a label for a user, much like a display name, along with the username which should be expected to be the unique identifier (while the label can be non-unique). It is a good idea because some integrations might want to supply this, and some might need a separate, unique identifier with which to easily identify the user being mentioned (like Nextcloud). Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> Change-Id: Id2484d5dee155a7755e0cca55a97d7191ec83985
elzody
force-pushed
the
feat/mention-label
branch
from
1c803d6 to
06b3fba
Compare
elzody
changed the title
3 tasks
Rash419
approved these changes
Nov 30, 2024
Rash419
requested changes
Nov 30, 2024
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> Change-Id: I6bb645725e1db84a6d21ee8c99230f3a6905fe3c
|
Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉 If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id:
Id2484d5dee155a7755e0cca55a97d7191ec83985Summary
In Nextcloud, we are working on improving our mention support, and it would be really nice to also be able to pass a display name (label) along with a username (unique identifier) and the profile link. Having this would allow us to determine the user quicker and easier on our side, and I don't see the harm in having it there for other integrations as well, should they want it.
This is a work-in-progress PR, and it's my first contribution to this repository, so please bear with me and provide any constructive feedback you may have :)
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay