cool#9992 doc electronic sign: allow more user private info settings with make run #10540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with make run Digital signing already supported .ca.pem / .cert.pem / .key.pem files next to documents in the no-integration case, but electronic signing would now bring 3 more similar settings, and this isn't really scaling. FileServer.cpp handleWopiRequest() already builds a JSON dictionary from these files, so it would be natural to allow any other UserPrivateInfo keys as well in files next to local documents. Fix the problem by reading a single .user-private-info.json file instead, which means that setting any user private info keys is now possible without explicit support by the local file WOPI backend. Adapt the only cypress test that used the old format accordingly. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ic833821074e622d12933c42a127e4193ade46ca8
|
@caolanm could you please review this? Thanks. #9992 (comment) has a sample JSON to show how this looks like in practice, so we have something more generic and not increasing 3 specific settings to 6 ones. |
caolanm
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digital signing already supported .ca.pem / .cert.pem / .key.pem files
next to documents in the no-integration case, but electronic signing
would now bring 3 more similar settings, and this isn't really scaling.
FileServer.cpp handleWopiRequest() already builds a JSON dictionary from
these files, so it would be natural to allow any other UserPrivateInfo
keys as well in files next to local documents.
Fix the problem by reading a single .user-private-info.json file
instead, which means that setting any user private info keys is now
possible without explicit support by the local file WOPI backend.
Adapt the only cypress test that used the old format accordingly.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Ic833821074e622d12933c42a127e4193ade46ca8