cool#9992 doc sign: add menu item for the compact UI #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open Writer, switch to the compact (menu-based) UI, notice the file menu has no entry to add a signature. This is primarily interesting as notebookbar is our default, but PDF files are still opened in compact & read-only mode by default. Fix the problem by adding a menu entry to all 4 components in the menu bar, at a position similar to the desktop. Also the notebookbar button was missing for the Draw case, fix that. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I9af4e42d11f4717a3ab6c5e25b237dd35c407410
|
@caolanm could you please review this? Thanks. PDF sign is still impossible because PDF is opened in a read-only Draw view, but this at least sorts out all combinations of Writer/Calc/Draw/Impress and notebookbar/compact UI. |
caolanm
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Writer, switch to the compact (menu-based) UI, notice the file menu
has no entry to add a signature.
This is primarily interesting as notebookbar is our default, but PDF
files are still opened in compact & read-only mode by default.
Fix the problem by adding a menu entry to all 4 components in the menu
bar, at a position similar to the desktop.
Also the notebookbar button was missing for the Draw case, fix that.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: I9af4e42d11f4717a3ab6c5e25b237dd35c407410