cool#9992 doc sign: move sign key/cert init from doc init to sign dispatch #10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patch core.git commit d48264d51891d81f77fcfd77766e1d34ec17412b (cool#9992 lok doc sign: allow late-init of the sign cert, 2024-10-22) allows sending the sign key/cert only when actually signing. Also commit 7998ba5 (fix uno:Signature cypress test, etc., 2024-10-23) already started to annotate .uno:Signature with sign parameters. Complete this move by: 1) Extracting the .uno:Signature handling code to a separate function, since ChildSession::_handleInput() is large enough already. 2) Poco::Dynamic::Var::extract() can throw an exception if the user private info is not an object (but is e.g. a list), guard against that. 3) Stop sending the sign cert/key in Document::makeRenderParams(). Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I426c0dc8b028eb874f0baf6b99f5c803ad8078d7
retry. |
|
@caolanm could you please review this? Thanks. This does the cleanup you suggested, also gets rid of the manual escaping in the string literal, which is ~fine, but I easily get it wrong myself, so I switched to the json writer to get some safety. |
caolanm
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.git commit d48264d51891d81f77fcfd77766e1d34ec17412b (cool#9992 lok
doc sign: allow late-init of the sign cert, 2024-10-22) allows sending
the sign key/cert only when actually signing.
Also commit 7998ba5 (fix uno:Signature
cypress test, etc., 2024-10-23) already started to annotate
.uno:Signature with sign parameters.
Complete this move by:
Extracting the .uno:Signature handling code to a separate function,
since ChildSession::_handleInput() is large enough already.
Poco::Dynamic::Var::extract() can throw an exception if the user
private info is not an object (but is e.g. a list), guard against
that.
Stop sending the sign cert/key in Document::makeRenderParams().
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: I426c0dc8b028eb874f0baf6b99f5c803ad8078d7