cool#9992 doc sign: set the view's sign cert from the WOPI UserPrivateInfo #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eInfo To be able to sign documents, at least the 'local file' WOPI provider sets 3 keys under UserPrivateInfo to give the wsd, and then the kit process the signing certificate. The other end is the core side, which takes 3 keys as a view options in initializeForRendering(). What was missing is to connect these two: this way a 'make run' session can sign documents without hardcoding cert/key/ca PEM files anywhere. The integration side and cypress tests are not yet done here. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I1f847349e10336c69019c7f1747208e6be954362
But passes for me locally, retry. |
|
@caolanm could you please review this? Thanks. With this, the 'make run' case works for me, following the instructions at #9992 (comment). An actual integration still needs a bit of work, I see that we have an enable/disable flag for Zotero in the "capabilities", I need to look if that's relevant for signing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to sign documents, at least the 'local file' WOPI provider
sets 3 keys under UserPrivateInfo to give the wsd, and then the kit
process the signing certificate.
The other end is the core side, which takes 3 keys as a view options in
initializeForRendering().
What was missing is to connect these two: this way a 'make run' session
can sign documents without hardcoding cert/key/ca PEM files anywhere.
The integration side and cypress tests are not yet done here.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: I1f847349e10336c69019c7f1747208e6be954362