cool#9992 doc sign: local file wopi provider: allow setting the sign cert/key/ca #10172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caolanm could you please review this? Thanks. This is the local file wopi provider, available in --enable-debug builds. I'm still working on the shared wopi code part (that'll be relevant for both the 'make run' and the "nextcloud" case). |
caolanm
reviewed
Oct 4, 2024
wsd/FileServer.cpp
Outdated
| return {}; | ||
| } | ||
|
|
||
| std::string content; |
There was a problem hiding this comment.
this line looks like dead code
There was a problem hiding this comment.
Ah indeed, first I thought I can read into an std::string directly, then later it turned out I need a string stream instead. Let me fix.
…cert/key/ca Debugging the entire file storage -> COOL -> LO core chain in one step can be complex, issues are easier to investigate if a COOL 'make run' setup can also reproduce the problem. Not to mention that testing with cypress is easier if the test case doesn't require an integration. Signing certificates are meant to be handled similar to previous secrets like the Zotero API key, but that only works with a file storage integration. Solve the problem by looking for files next to the loaded document for the 'local file' WOPI provider (in debug mode). So for example test.odt looks for files named test.odt.cert.pem, test.odt.key.pem and test.odt.ca.pem: if those exist, then you can sign the document without an integration. The kit process in Document::load() doesn't make use of this sign data yet, though. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ib382d7e843b5f6ff5cd101291ce897628e312af8
vmiklos
force-pushed
the
private/vmiklos/sign
branch
from
effd6c1 to
3015582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the entire file storage -> COOL -> LO core chain in one step
can be complex, issues are easier to investigate if a COOL 'make run'
setup can also reproduce the problem. Not to mention that testing with
cypress is easier if the test case doesn't require an integration.
Signing certificates are meant to be handled similar to previous secrets
like the Zotero API key, but that only works with a file storage
integration.
Solve the problem by looking for files next to the loaded document for
the 'local file' WOPI provider (in debug mode). So for example test.odt
looks for files named test.odt.cert.pem, test.odt.key.pem and
test.odt.ca.pem: if those exist, then you can sign the document without
an integration.
The kit process in Document::load() doesn't make use of this sign data
yet, though.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Ib382d7e843b5f6ff5cd101291ce897628e312af8