protect asyncInstall lifecycle

RequestVettingStation can complete and take down its PresetsInstallTask if the required subforkit is already available Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I7b2ec831158022e904bb28223053150543a2a241
CollaboraOnline · Feb 27, 2025 · db0d649 · db0d649
1 parent 455defb
commit db0d649
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
@@ -1501,8 +1501,12 @@ DocumentBroker::updateSessionWithWopiInfo(const std::shared_ptr<ClientSession>&
 void PresetsInstallTask::asyncInstall(const std::string& uri, const std::string& stamp, const std::string& fileName,
                                       const std::shared_ptr<ClientSession>& session)
 {
-    auto presetInstallFinished = [this](const std::string& id, bool presetResult)
+    auto presetInstallFinished = [selfWeak = weak_from_this(), this](const std::string& id, bool presetResult)
     {
+        std::shared_ptr<PresetsInstallTask> selfLifecycle = selfWeak.lock();
+        if (!selfLifecycle)
+            return;
+
         installPresetFinished(id, presetResult);
     };