Improve default options and behaviour. #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CogentRedTester
force-pushed
the
new-defaults
branch
from
717afb4 to
5b0f3ea
Compare
This removes the LuaJit requirements. This is still rather experimental, so there may be bugs that appear when parsing non-spec UTF16 strings (which Windows apparently supports in filepaths!?). To address this the parser is set to throw errors on any invalid input. If an error is thrown the parser will abort and file-browser will fallback to the default parser.
CogentRedTester
force-pushed
the
new-defaults
branch
from
5a57a91 to
e7ee666
Compare
CogentRedTester
commented
Mar 11, 2025
| return true | ||
| end | ||
|
|
||
| ---@param file string | ||
| ---@return boolean | ||
| function fb_utils.valid_file(file) | ||
| if o.filter_dot_files and (string.sub(file, 1, 1) == ".") then return false end | ||
| if o.filter_dot_dirs == 'yes' or o.filter_dot_dirs == 'auto' and g.PLATFORM ~= 'windows' then |
There was a problem hiding this comment.
Suggested change
| if o.filter_dot_dirs == 'yes' or o.filter_dot_dirs == 'auto' and g.PLATFORM ~= 'windows' then | |
| if o.filter_dot_files == 'yes' or o.filter_dot_files == 'auto' and g.PLATFORM ~= 'windows' then |
CogentRedTester
commented
Mar 11, 2025
Comment on lines
+85
to
+87
| error(('malformed utf16le string at byte #%d (0x%04X) - high surrogate pair should be >= 0xdc00'):format(i+2, high_pair)) | ||
| elseif low_pair < 0xdc00 then | ||
| error(('malformed utf16le string at byte #%d (0x%04X) - low surrogate pair should be < 0xdc00'):format(i+3, low_pair)) |
There was a problem hiding this comment.
Suggested change
| error(('malformed utf16le string at byte #%d (0x%04X) - high surrogate pair should be >= 0xdc00'):format(i+2, high_pair)) | |
| elseif low_pair < 0xdc00 then | |
| error(('malformed utf16le string at byte #%d (0x%04X) - low surrogate pair should be < 0xdc00'):format(i+3, low_pair)) | |
| error(('malformed utf16le string at byte #%d (0x%04X) - high surrogate pair should be < 0xDC00'):format(i, high_pair)) | |
| elseif low_pair < 0xdc00 then | |
| error(('malformed utf16le string at byte #%d (0x%04X) - low surrogate pair should be >= 0xDC00'):format(i+2, low_pair)) |
CogentRedTester
commented
Mar 11, 2025
Comment on lines
+73
to
+74
| local big = lshift(get_byte(), 8) | ||
| local codepoint = big + little |
There was a problem hiding this comment.
Suggested change
| local big = lshift(get_byte(), 8) | |
| local codepoint = big + little | |
| local big = get_byte() | |
| local codepoint = little + lshift(big, 8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to do a wide update of file-browsers default options and behaviour
to make things more user friendly.
File-browser is several years old now, and in that time there are some legacy options
that can be improved, and some experimental features that now provide a superior
experience.