Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ParentPath on file copy if available #1579

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1577

Proposed changes

Seems there are some inconsistencies across node versions when it comes to the paths when traversing directories. With this PR we use the parentPath if available.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jul 13, 2024
@Danielku15 Danielku15 merged commit d987ff6 into develop Jul 13, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/node-lts-copy-path branch July 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite-plugin-alphatab-copy: path computing issue on github pages / maybe Ubuntu in general
1 participant