Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Card + FloatingCard)!: changing FloatCard to internal use and refactoring Card #3042

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 21, 2025

Overview

Making FloatingCard an internal component, for Gamut use only.
The styling that FloatingCard provided is now in the Card component, such as:

  • a shadow effect on hover
  • an optional pattern SVG behind the Card

Other changes:

  • FloatingCard is renamed to InternalFloatingCard and marked as deprecated
  • Card now has variants that uses the variant util function
  • Card elements are based off framer motion and provide small animations for the hover effect
  • Card takes on a medium border radius and a shadow hover when isInteractive prop is true (i.e. in a link, or button, or has a clickable area inside the body of the Card)
  • A Card that is not interactive will have a none border radius by default

PR Checklist

Testing Instructions

  1. Go to the Card story
  2. Look over the examples see that examples make sense and work, esp the isInteractive section
  3. Look over the InternalFloatingCard story - notice the callout and the status of "Old Style".
  4. Look over components that use InternalFloatingCard, like Modal, Toast and see that they still work and are ok.
  5. ...
  6. Profit?!

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal App Monorepo Link Portal Env
LE Preview Monorepo Link LE Env
Brand Monorepo Link Storybook

Copy link

nx-cloud bot commented Feb 21, 2025

View your CI Pipeline Execution ↗ for commit 6718ba8.


☁️ Nx Cloud last updated this comment at 2025-03-20 19:06:51 UTC

@LinKCoding LinKCoding changed the title refactor(FloatingCard): changing FloatCard to internal use and refactoring Card refactor(Card + FloatingCard)!: changing FloatCard to internal use and refactoring Card Mar 19, 2025
@LinKCoding LinKCoding marked this pull request as ready for review March 20, 2025 19:02
@LinKCoding LinKCoding requested a review from a team as a code owner March 20, 2025 19:02
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@59.3.1-alpha.6718ba.0
@codecademy/gamut-kit@0.6.488-alpha.6718ba.0
@codecademy/styleguide@70.5.1-alpha.6718ba.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67dc6760f5f9d05c914f98a3--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding requested a review from dreamwasp March 20, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants