-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Card + FloatingCard)!: changing FloatCard to internal use and refactoring Card #3042
Open
LinKCoding
wants to merge
60
commits into
main
Choose a base branch
from
kl-gm-925
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 6718ba8. ☁️ Nx Cloud last updated this comment at |
📬Published Alpha Packages:@codecademy/gamut@59.3.1-alpha.6718ba.0 |
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Making
FloatingCard
an internal component, for Gamut use only.The styling that
FloatingCard
provided is now in theCard
component, such as:Other changes:
FloatingCard
is renamed toInternalFloatingCard
and marked as deprecatedCard
now has variants that uses thevariant
util functionCard
elements are based off framer motion and provide small animations for the hover effectCard
takes on a medium border radius and a shadow hover whenisInteractive
prop istrue
(i.e. in a link, or button, or has a clickable area inside the body of theCard
)Card
that is not interactive will have anone
border radius by defaultPR Checklist
Testing Instructions
InternalFloatingCard
, like Modal, Toast and see that they still work and are ok.PR Links and Envs