Changed findElement to avoid having to put the selectors of every pare… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like a solution compatible with my application loaded like SHADY or SHADOW.
To do that we need a more flexible selector strategy in which one we don't have to put the selectors of every parent web-component. In this way I would like to make the tests much less coupled with the internal structure of the web components.
For example, in the following page:
.. ``
Currently, to select the anchor, you have to use the "shop-app shop-homeshop-button a" selector.
But with this patch, you can just simple use "shop-button a" or "shop-app shop-button a" like valid selectors.