Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HER-72: Define User roles #52

Merged
merged 5 commits into from
Jan 11, 2025
Merged

HER-72: Define User roles #52

merged 5 commits into from
Jan 11, 2025

Conversation

olesiamironenko
Copy link
Collaborator

Issue HER-72: Define User roles

https://raquelanaroman.atlassian.net/browse/HER-72

Changes

  1. Updated user roles in user model.
  2. Updated users factory: added traits for each user role.
  3. Updated other factories to comply with traits from users factory where needed
  4. Updated models and controllers tests to comply with traits from users factory where needed

Review Checklist

  • I have documented my code with code comments.

Copy link
Collaborator

@trca831 trca831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

role { "user" }
end

trait :guest_user do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe we don't need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are ritght on this. updating

@olesiamironenko olesiamironenko merged commit 6b3325f into main Jan 11, 2025
3 checks passed
@olesiamironenko olesiamironenko deleted the HER-72-define-user-roles branch January 11, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants