-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send RunPart
metadata to upload endpoint
#57
feat: send RunPart
metadata to upload endpoint
#57
Conversation
06848b2
to
9b963a3
Compare
dfdd096
to
4de349f
Compare
7490e74
to
702328e
Compare
@adriencaccia @Arthur I updated and also added some tests |
702328e
to
ed81950
Compare
@art049 sorry about the force-pushes. Here is the comparison link between the reviewed and the latest version: https://github.com/CodSpeedHQ/runner/compare/f87e92ed46b24c5635282521365023e1a31571d5..ed81950a62afe82f0c8d2839fa940d46ea9bc5a3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed together, it would be best to just keep job-index and job-total in the last part of the matrix part id
@adriencaccia I removed some values from the metadata, can you release a new beta version? |
58523ef
to
f5f1005
Compare
f5f1005
to
2a75794
Compare
2a75794
to
c999e1d
Compare
c999e1d
to
b694997
Compare
@adriencaccia updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting on @art049
826032c
to
b694997
Compare
No description provided.