Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send RunPart metadata to upload endpoint #57

Merged

Conversation

fargito
Copy link
Member

@fargito fargito commented Jan 15, 2025

No description provided.

@fargito fargito self-assigned this Jan 15, 2025
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch 20 times, most recently from 06848b2 to 9b963a3 Compare January 16, 2025 12:55
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch 9 times, most recently from dfdd096 to 4de349f Compare January 27, 2025 12:46
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from 7490e74 to 702328e Compare January 29, 2025 17:48
@fargito
Copy link
Member Author

fargito commented Jan 29, 2025

@adriencaccia @Arthur I updated and also added some tests

@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from 702328e to ed81950 Compare January 29, 2025 18:35
@fargito
Copy link
Member Author

fargito commented Jan 30, 2025

@art049 sorry about the force-pushes. Here is the comparison link between the reviewed and the latest version: https://github.com/CodSpeedHQ/runner/compare/f87e92ed46b24c5635282521365023e1a31571d5..ed81950a62afe82f0c8d2839fa940d46ea9bc5a3

Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed together, it would be best to just keep job-index and job-total in the last part of the matrix part id

@art049 art049 self-requested a review January 31, 2025 12:53
@fargito
Copy link
Member Author

fargito commented Jan 31, 2025

@adriencaccia I removed some values from the metadata, can you release a new beta version?

@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch 3 times, most recently from 58523ef to f5f1005 Compare February 13, 2025 16:30
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from f5f1005 to 2a75794 Compare February 13, 2025 16:31
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from 2a75794 to c999e1d Compare February 14, 2025 09:52
@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from c999e1d to b694997 Compare February 14, 2025 10:28
@fargito
Copy link
Member Author

fargito commented Feb 14, 2025

@adriencaccia updated

@fargito fargito requested a review from adriencaccia February 14, 2025 10:28
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting on @art049

@fargito fargito force-pushed the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch from 826032c to b694997 Compare February 17, 2025 16:42
@fargito fargito merged commit b694997 into main Feb 19, 2025
18 checks passed
@fargito fargito deleted the cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the branch February 19, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants